Re: [PATCH] use CGI.pm;

On Wed, Sep 08, 1999 at 10:19:34PM +0200, Terje Bless wrote:
> Here is the patch (against 1.31) to make "check" use CGI.pm. It does away
> with the ability to put parameters in path info, but includes a special
> case to allow you continue to use "/check/referer" to check the referer.
> 
> It's been reasonably well tested, so I don't anticipate any problems, but
> as it's a fairly comprehenive change something may have snuck in. If any
> problems pop up I'll try to fix them ASAP.

Thanks for the patch.

I integrated it into the current script, and have it running on
my test server:

    http://validator.w3.org:8000/

It's not committed to CVS yet, but here is the current code
(on the test server):

    http://validator.w3.org:8000/dev/check-current.txt

Almost all of my test cases seem to work:

    http://validator.w3.org:8000/dev/tests/

except this syntax doesn't seem to be supported by CGI.pm:

    http://validator.w3.org:8000/check?uri=http://www.w3.org/;ss;sp;outline

and I'm not sure how to fix that.

At first I thought it was my use of semicolons instead of ampersands
between the CGI parameters, but that's not it; CGI.pm splits on
either '&' or ';' . This doesn't work either:

    http://validator.w3.org:8000/check?uri=http://www.w3.org/&ss&sp&outline

It wants '=' after the parameters, or else they don't get defined.
This works:

    http://validator.w3.org:8000/check?uri=http://www.w3.org/&ss=&sp=&outline=

Any ideas how to support the old syntax as well?

-- 
Gerald Oskoboiny       <gerald@w3.org>  +1 617 253 2920
System Administrator   http://www.w3.org/People/Gerald/
World Wide Web Consortium (W3C)      http://www.w3.org/

Received on Tuesday, 28 September 1999 19:39:49 UTC