W3C home > Mailing lists > Public > www-style@w3.org > October 2016

Re: PROPOSED RESOLUTION: merge csswg-test into web-platform-tests

From: Gérard Talbot <www-style@gtalbot.org>
Date: Sat, 01 Oct 2016 17:08:51 -0400
To: Geoffrey Sneddon <me@gsnedders.com>
Cc: Public www-style mailing list <www-style@w3.org>
Message-ID: <bbb3548bd046fa001cdd30761ac5ddc1@gtalbot.org>
Le 2016-09-29 11:58, Geoffrey Sneddon a écrit :
> On Tue, Sep 27, 2016 at 11:44 PM, Gérard Talbot
> <css21testsuite@gtalbot.org> wrote:
>> Le 2016-09-27 12:23, Geoffrey Sneddon a écrit :
>>> 3. Ensure web-platform-tests's documentation is up-to-date and
>>> cohesive, both for submitting tests and reviewing them.
>> 
>> 
>> Geoffrey,
>> 
>> My main request regarding reviewing tests is that reviewing tasks
>> (procedures, steps, requirements, areas to check, what's decisive,
>> important, critical, etc) will be specified and explicit: what should 
>> be
>> reviewed, how it should be reviewed, what test authors should expect, 
>> what
>> is expected from reviewers, from a review, etc... would be specified 
>> and
>> explicit. The current documentation is, in my opinion, already doing 
>> an
>> excellent job in that regard as it covered a wide range of possible
>> situations and parameters.
> 
> Our current documentation seems to be primarily
> <http://testthewebforward.org/docs/review-checklist.html>, given the
> old documentation at <https://wiki.csswg.org/test/review> has a big
> notice at the top. Is there some other documentation I've missed
> somewhere?

2 elements that should be added are:

o) "The test contains no extraneous content. Unneeded containers, 
unneeded css-resets unrelated to the test goal and unneeded to the test 
goal should be avoided."

I often see tests that use unneeded containers, unneeded css-resets 
unrelated to the test goal and unneeded to the test goal.

oo) Test authors should be formally encouraged to reuse already created, 
already available and reviewed support files and reference files. Test 
authors should be discouraged from creating new support files and new 
reference files. For countless of reasons.

Also, the detailed review checklist
https://wiki.csswg.org/test/css2.1/review-checklist
should be mentioned somewhere for those who want to make their test as 
best as possible.

Gérard
Received on Saturday, 1 October 2016 21:09:25 UTC

This archive was generated by hypermail 2.4.0 : Monday, 23 January 2023 02:15:01 UTC