pychecker warns of problems in cwm/llyn/thing source

pychecker is a static analysis tool for python
http://pychecker.sourceforge.net/

It has the following to say about cwm; some
of these are noise, but many of them seem
to point out dead code, brokenness, etc.

Here's a classic:
  llyn.py:1840: Function (query) has too many lines (322)

--8<--
cd /home/connolly/w3ccvs/WWW/2000/10/swap/
pychecker cwm.py
Processing cwm...

Warnings...

RDFSink.py:106: Parameter (isList) not used

cwm.py:34: Using import and from ... import for (thing)
cwm.py:40: Imported module (binascii) not used
cwm.py:40: Imported module (md5) not used
cwm.py:49: Using import and from ... import for (thing)
cwm.py:130: Local variable (t5) not used
cwm.py:171: Local variable (thisDoc) not used
cwm.py:223: No global (StringIO) found
cwm.py:236: self is argument in function
cwm.py:241: Function returns a value and also implicitly returns None
cwm.py:242: Parameter (seed) not used
cwm.py:262: Function (doCommand) has too many branches (51)
cwm.py:262: Function (doCommand) has too many lines (327)
cwm.py:262: Function (doCommand) has too many local variables (43)
cwm.py:303: Module (thing) re-imported
cwm.py:315: Local variable (option_outURI) not used
cwm.py:318: Local variable (option_meta) not used
cwm.py:326: Local variable (hostname) not used
cwm.py:333: Local variable (option_first_format) not used
cwm.py:395: Global variable (sax2rdf) defined without being declared
cwm.py:431: Local variable (history) not used
cwm.py:474: Local variable (s) not used

llyn.py:534: Local variable (daml) not used
llyn.py:695: Function returns a value and also implicitly returns None
llyn.py:779: No global (quadToStr) found
llyn.py:941: Statement appears to have no effect
llyn.py:1064: Function (isList) has too many returns (11)
llyn.py:1144: No global (noendtolist) found
llyn.py:1236: Modifying parameter (statements) with a default value may have unexpected consequences
llyn.py:1264: Modifying parameter (statements) with a default value may have unexpected consequences
llyn.py:1738: Local variable (count) not used
llyn.py:1840: Function (query) has too many branches (85)
llyn.py:1840: Function (query) has too many lines (322)
llyn.py:1840: Function (query) has too many returns (20)
llyn.py:1869: Modifying parameter (bindings) with a default value may have unexpected consequences
llyn.py:2017: No global (notimp) found
llyn.py:2161: No global (canNotResolve) found
llyn.py:2164: Parameter (bindings) not used
llyn.py:2164: Parameter (param) not used

thing.py:137: self is argument in function
thing.py:161: No global (internalError) found

Compilation finished at Fri Feb 22 08:47:24
--8<--


Some version info:

connolly@jammer:~/w3ccvs/WWW/2000/10/swap$ ident thing.py cwm.py llyn.py
thing.py:
     $Id: thing.py,v 1.7 2001/12/08 02:45:56 timbl Exp $

cwm.py:
     $Id: cwm.py,v 1.84 2002/02/14 23:56:09 connolly Exp $
     $Id: cwm.py,v 1.84 2002/02/14 23:56:09 connolly Exp $

llyn.py:
     $Id: llyn.py,v 1.13 2002/02/14 23:56:09 connolly Exp $

Received on Monday, 25 February 2002 10:11:14 UTC