- From: Nic Steenhout <nic@knowbility.org>
- Date: Tue, 14 Nov 2017 09:59:01 -0500
- To: Shadi Abou-Zahra <shadi@w3.org>
- Cc: "Keen, Laura" <lkee@loc.gov>, EO Editors <wai-eo-editors@w3.org>
- Message-ID: <CAMBJsFAMCrtV=wB4Y0Ey-vWaEt9ErMEN7uL-OcwjZ0QOhcDQgQ@mail.gmail.com>
Thanks Shadi, Regarding #1, I'll adjust that. We need a heading, but your point does make sense. Regarding #3, it's in the EO style guide Regarding #4, I'll move it up. As I wasn't able to simply merge your pull request, I had to go through the file manually and obviously missed it. Regarding #2, I'm honestly not seeing it, and I'm not sure how it is the same underlying issue. But I'll have a look. I'll update #1, and #4 momentarily. Nic On Tue, Nov 14, 2017 at 9:11 AM, Shadi Abou-Zahra <shadi@w3.org> wrote: > Hi Nic, > > I only had time to do a quick skim, but many thanks for addressing many of > my concerns! Just a few things that caught my attention, though: > > - I still don't really like the heading "Features You Can Use as a > Filter". It just does not make sense to me on this page, if I'm not aware > of the tools list. It takes quite some mind work (eg read the *prior* > paragraph) to understand the context. > > - I find the tone and approach of the descriptions rather inconsistent and > confusing. Often you are describing the functionality of the tools list > rather than the actual tool feature itself. > > - Not sure about use of "e.g." and "etc.". I don't like that style > (personal opinion), but don't know if it is covered in the EO guide. > > - "Accessibility Information" is actually a feature that you can sort by. > I had moved it up. Not sure if you disagree or just missed it. > > > Are these comments helpful for you, or do you prefer that I raise them as > issues or put them in another pull request? > > Best, > Shadi > > > > On 13/11/2017 21:05, Nic Steenhout wrote: > >> Hello Shadi, >> >> Laura and I have, we think, finalized and incorporated the changes you >> suggested to the Selecting evaluation tools page. >> >> https://github.com/w3c/wai-selecting-eval-tools/blob/master/index.md >> >> I had to rewrite the page manually as I was not able to merge only parts >> of your pull request. >> >> We both like how the page is looking at the moment. >> >> Could you have a look and if things are good on your front, we'll be able >> to initiate a request for review from the whole group this Friday! >> >> Thank you >> >> Nic >> > > -- > Shadi Abou-Zahra - http://www.w3.org/People/shadi/ > Accessibility Strategy and Technology Specialist > Web Accessibility Initiative (WAI) > World Wide Web Consortium (W3C) >
Received on Tuesday, 14 November 2017 14:59:24 UTC