[whatwg] URL: spec review - basic_parser

I've now completed step 1, as described at [1].

Here are my questions/comments:

1) https://url.spec.whatwg.org/#url-code-points
    U+D8000 to U+DFFFD are invalid as they are within the UTF-16
    surrogate range

2) https://url.spec.whatwg.org/#concept-basic-url-parser
    I'm interpreting "terminate this algorithm" and "return failure" to
    mean the same thing, and I'm interpreting "parse error" as "set
    parse error flag and continue".

3) https://url.spec.whatwg.org/#authority-state
    a) Did you really mean prepend in Step 1.1?

    b) Step 1.3.3 seems problematic.  I interpret this prose to mean "if
       any character in buffer is a "%" and the first two characters
       after the pointer position in input aren't hex characters".
       Specifically, it appears to be comparing a possibly
       non-contiguous set of characters.

4) https://url.spec.whatwg.org/#file-host-state
    Step 1.3.2 returns failure without setting parse_error.  Is this

5) https://url.spec.whatwg.org/#host-state
    Step 1.2.2 also returns failure without setting parse_error.

6) https://url.spec.whatwg.org/#relative-path-state
    If input contains a path but no query or fragment, the last part of
    the path will be accumulated into buffer, but that buffer will never
    be added to the path

- Sam Ruby

[1] http://lists.w3.org/Archives/Public/www-tag/2014Oct/0053.html

Received on Saturday, 11 October 2014 00:19:25 UTC