W3C home > Mailing lists > Public > public-webrtc@w3.org > May 2014

Re: renaming updateIce

From: Justin Uberti <juberti@google.com>
Date: Wed, 30 Apr 2014 17:14:25 -0700
Message-ID: <CAOJ7v-2iyF014cDKVGTo6nbN6Afi7pdQhFgro10=MrpFPHNbKw@mail.gmail.com>
To: "Cullen Jennings (fluffy)" <fluffy@cisco.com>
Cc: "public-webrtc@w3.org" <public-webrtc@w3.org>
Understood. If we want setConfiguration to be appropriate, we would need to
change the behavior from update to overwrite.

so, updateConfiguration SGTM.


On Wed, Apr 30, 2014 at 1:16 PM, Cullen Jennings (fluffy)
<fluffy@cisco.com>wrote:

>
> On Apr 29, 2014, at 11:26 PM, Justin Uberti <juberti@google.com> wrote:
>
> > Since RTCConfiguration is no longer solely about ICE, and we now have
> PeerConnection.getConfiguration(), I propose that
> PeerConnection.updateIce() be renamed to
> PeerConnection.updateConfiguration(), or perhaps even
> PeerConnection.setConfiguration().
> >
> > Any objections to this change?
>
> updateConfiguration seems good but I don’t like setConfiguration because
> that is not what it does
>
>
>
Received on Thursday, 1 May 2014 00:15:16 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 15:19:40 UTC