Re: renaming updateIce

Understood. If we want setConfiguration to be appropriate, we would need to
change the behavior from update to overwrite.

so, updateConfiguration SGTM.


On Wed, Apr 30, 2014 at 1:16 PM, Cullen Jennings (fluffy)
<fluffy@cisco.com>wrote:

>
> On Apr 29, 2014, at 11:26 PM, Justin Uberti <juberti@google.com> wrote:
>
> > Since RTCConfiguration is no longer solely about ICE, and we now have
> PeerConnection.getConfiguration(), I propose that
> PeerConnection.updateIce() be renamed to
> PeerConnection.updateConfiguration(), or perhaps even
> PeerConnection.setConfiguration().
> >
> > Any objections to this change?
>
> updateConfiguration seems good but I don’t like setConfiguration because
> that is not what it does
>
>
>

Received on Thursday, 1 May 2014 00:15:16 UTC