Re: [mediacapture-region] Make CropTarget serializable (#24)

> Overall it seems fine. I would go with forStorage=false as a first step.
> 
> Also, if serialising then deserialising, we should get an equivalent object (representing the same element) but not exactly the same object. I wonder whether we could have CropTarget have an internal slot storing its element. Then the serialisation and deserialisation steps would be about reading/setting the CropTarget internal slot.

Done with an internal slot for the serialized object, but not for CropTarget, where that would be a different topic. PTAL at the PR.

-- 
GitHub Notification of comment by eladalon1983
Please view or discuss this issue at https://github.com/w3c/mediacapture-region/pull/24#issuecomment-1072558437 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 18 March 2022 16:07:34 UTC