Re: [webrtc-pc] pc.close() should null out currentDirection (#2122)

My understanding of currentDirection is that it means the "direction currently negotiated", which is why it is updated at setLocalDescription(answer) and setRemoteDescription(answer). Stopping a transceiver is something that needs to be negotiated, which has not been done at either stop() or close(). Setting "stopped" to true is the right thing to do. But touching currentDirection? I'm not sure.

Probably direction should be made inactive and become readonly. But currentDirection? I can't say that it matters much and we can do "whatever shipped implementations does", but to me it does sound like it goes against what it is meant to mean.

-- 
GitHub Notification of comment by henbos
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2122#issuecomment-470870276 using your GitHub account

Received on Friday, 8 March 2019 09:51:20 UTC