W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > January 2019

Re: [webrtc-stats] Move (fir|pli|nack|sli)Count and qpSum out of baseclass to (in|out)bound (#384)

From: Varun Singh via GitHub <sysbot+gh@w3.org>
Date: Wed, 23 Jan 2019 14:19:24 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-456817796-1548253163-sysbot+gh@w3.org>
When it was in the base class, the ambigious *Count name made sense because the text described how the counters were updated at the sender and receiver. Now that these metrics are being moved to the appropriate dictionary, we can add the suffix -Sent/-Received qualifier. 

If we are going down this path, I would encourage the -suffix, but that would require retiring the -Count metrics.

Browsers that have implemented these -Count metrics should also chime in? @henbos @aboba @jan-ivar @youennf 

-- 
GitHub Notification of comment by vr000m
Please view or discuss this issue at https://github.com/w3c/webrtc-stats/pull/384#issuecomment-456817796 using your GitHub account
Received on Wednesday, 23 January 2019 14:19:26 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:54 UTC