Re: [w3c/payment-handler] Update Example6 and Example7 (#290)

romandev commented on this pull request.



>  
-    e.source.postMessage(paymentAppResponse);
-    window.close();
-  }
+  navigator.serviceWorker.controller.postMessage(paymentAppResponse);
+  window.close();

If you don't mind, I'll keep this PR for now until https://github.com/w3c/payment-handler/issues/300 issue is resolved.
A few month ago, I left a review comment in CL: https://chromium-review.googlesource.com/c/chromium/src/+/1019941#message-063bd9d764584bf84445f34f2afb435a25b5d8db
I don't remember exactly but I think closing opened window by `respondWith()`'s promise seems a little bit strange to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/290#discussion_r219131995

Received on Thursday, 20 September 2018 11:48:10 UTC