W3C home > Mailing lists > Public > public-webauthn@w3.org > June 2022

Re: [webauthn] New PublicKeyCredential methods for JSON (de)serialization (#1703)

From: Matthew Miller via GitHub <sysbot+gh@w3.org>
Date: Mon, 20 Jun 2022 14:01:21 +0000
To: public-webauthn@w3.org
Message-ID: <issue_comment.created-1160486880-1655733678-sysbot+gh@w3.org>
I haven't chimed in because @dwaite and @emlun beat me to my responses. I'm glad to see my intuition was right about how best to handle those values 🙂

Most of the feedback has been handled on my end. The one outstanding change suggestion that I know about right now is the suggestion to include directions for what to do if bad data is passed into these objects, namely throwing an `EncodingError`. Can someone please look over my addition that attempts to address that? This thing is so close to being ready, I'm very excited 😅 

-- 
GitHub Notification of comment by MasterKale
Please view or discuss this issue at https://github.com/w3c/webauthn/pull/1703#issuecomment-1160486880 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Monday, 20 June 2022 14:01:22 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:46 UTC