Re: [webauthn] New PublicKeyCredential methods for JSON (de)serialization (#1703)

I haven't chimed in because @dwaite and @emlun beat me to my responses. I'm glad to see my intuition was right about how best to handle those values 🙂

Most of the feedback has been handled on my end. The one outstanding change suggestion that I know about right now is the suggestion to include directions for what to do if bad data is passed into these objects, namely throwing an `EncodingError`. Can someone please look over my addition that attempts to address that? This thing is so close to being ready, I'm very excited 😅 

GitHub Notification of comment by MasterKale
Please view or discuss this issue at using your GitHub account

Sent via github-notify-ml as configured in

Received on Monday, 20 June 2022 14:01:22 UTC