W3C home > Mailing lists > Public > public-webauthn@w3.org > June 2022

Re: [webauthn] New PublicKeyCredential methods for JSON (de)serialization (#1703)

From: Matthew Miller via GitHub <sysbot+gh@w3.org>
Date: Thu, 09 Jun 2022 19:40:42 +0000
To: public-webauthn@w3.org
Message-ID: <issue_comment.created-1151548572-1654803640-sysbot+gh@w3.org>
I just tweaked the options parsing method names after a quick sanity check during the F2F:

- `getCreationOptionsFromJSON()` -> `parseCreationOptionsfromJSON()`
- `getRequestOptionsFromJSON()` -> `parseRequestOptionsFromJSON()`

Hopefully this is an acceptable compromise to feedback that "get" might be confusing since `navigator.credentials.get()` is one of the WebAuthn methods.

GitHub Notification of comment by MasterKale
Please view or discuss this issue at https://github.com/w3c/webauthn/pull/1703#issuecomment-1151548572 using your GitHub account

Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 9 June 2022 19:40:43 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:46 UTC