W3C home > Mailing lists > Public > public-webapps@w3.org > October to December 2015

Re: Can we land heycam's WebIDL tests as-is and address review comments following?

From: Simon Pieters <simonp@opera.com>
Date: Mon, 21 Dec 2015 10:10:04 +0100
To: public-webapps <public-webapps@w3.org>, "Zhang, Zhiqiang" <zhiqiang.zhang@intel.com>
Message-ID: <op.x9zk22jjidj3kv@simons-mbp>
On Mon, 21 Dec 2015 07:34:12 +0100, Zhang, Zhiqiang  
<zhiqiang.zhang@intel.com> wrote:

> Hi,
>
> 2+ years ago, heycam submitted WebIDL tests at
>
> https://github.com/w3c/web-platform-tests/pull/271
>
> These tests have been reviewed by several guys but get no update ever  
> since.
>
> I wonder if we could land the tests as-is and address the review  
> comments in further pull requests? Then we can make a test suite to  
> advance the specification and for people to understand the specification.
>
> Thoughts?
>
> Thanks,
> Zhiqiang

Personally I don't object to that plan, but an alternative is to create a  
new branch in w3c/web-platform-tests with these changes, and anyone with  
push access to w3c/web-platform-tests can make changes to that branch, and  
then we can merge to master when it's ready.

     git fetch origin refs/pull/271/head:refs/remotes/origin/pr/271 --force
     git checkout -b webidl-tests origin/pr/271
     git push -u origin webidl-tests

-- 
Simon Pieters
Opera Software
Received on Monday, 21 December 2015 09:10:36 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 18:14:58 UTC