W3C home > Mailing lists > Public > public-webapps@w3.org > April to June 2015

Re: [manifest] Manifest for web application; review ...

From: Kostiainen, Anssi <anssi.kostiainen@intel.com>
Date: Thu, 18 Jun 2015 06:38:37 +0000
To: timeless <timeless@gmail.com>
CC: public-webapps <public-webapps@w3.org>
Message-ID: <C25EBE9D-3F47-435A-A1D6-586EDB7DF359@intel.com>
> On 17 Jun 2015, at 18:11, Kostiainen, Anssi <anssi.kostiainen@intel.com> wrote:
> 
>> On 02 Jun 2015, at 00:58, timeless <timeless@gmail.com> wrote:
>> 
>> http://www.w3.org/TR/2015/WD-appmanifest-20150212/
> 
> Thanks for the detailed review. The pull request with you review feedback baked in is at:
> 
> https://github.com/w3c/manifest/pull/383
> 
> The changes should land after being reviewed, assuming no concerns.

The changes you proposed have landed:

  http://w3c.github.io/manifest/

[...]

>>> 8.4 src member
>>> Let value be the result of calling the [[GetOwnProperty]] internal method of icon passing "src" as the argument.
>>> Let type be Type(value).
>>> If type is not "string",
>>> or value is the empty string, then:
>> ^ this specific or branch isn't really necessary, one could just fall
>> through to the Trim path...
>>> If type is not "undefined", issue a developer warning that the type is unsupported.
>>> Return undefined.
>>> If Trim(value) is the empty string, then return undefined.
>> 
>> (I didn't read past this point)

Any further feedback would be much appreciated. For example, a similar, very detailed review for the remaining parts of the document.

Thanks,

-Anssi 
Received on Thursday, 18 June 2015 06:39:16 UTC

This archive was generated by hypermail 2.3.1 : Friday, 27 October 2017 07:27:31 UTC