W3C home > Mailing lists > Public > public-webapps@w3.org > July to September 2014

Re: RfC: pre-LC version of Screen Orientation; deadline August 18

From: Dominique Hazael-Massieux <dom@w3.org>
Date: Thu, 14 Aug 2014 09:21:28 +0200
Message-ID: <1408000888.3873.115.camel@cumulustier>
To: public-webapps <public-webapps@w3.org>
Le lundi 04 août 2014 à 08:19 -0400, Arthur Barstow a écrit :
> Marcos and Mounir, the Editors of WebApps' Screen Orientation API, 
> consider their spec feature complete with only a few minor [Bugs] open. 
> As such, we seek wide review on their "pre-LC" version:
> 
>    <https://w3c.github.io/screen-orientation/>
> 
> If you have any comments, please send them to public-webapps by August 
> 18 (and if you and/or your group need more time, please let me know.) We 
> also welcome data about "silent reviews", f.ex. "I reviewed section N.N 
> and have no comments".

A few comments:
* Promise<undefined> should be Promise<void> from my reading of WebIDL

* in the last paragraph of 5.1, the phrase "the screen as it is drawn"
was unclear to me until I read the lock orientation algorithm where the
phrase "the viewport is drawn" made it clearer; maybe the two can be
alined

* shouldn't the "apply an orientation lock" algorithm make reference to
the event firing? I was having trouble understanding steps 8.2 and 8.3
in the former until I arrived to the latter

* while I understand there is ongoing discussion on alignments with
DeviceOrientation, I'm less clear there is work to ensure consistency
with css-device-adapt; in particular, it seems like it would be useful
to understand how the two approaches work together when use
simultaneously

HTH,

Dom
Received on Thursday, 14 August 2014 07:21:55 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 18:14:26 UTC