Re: Need review of PHP file in Progress Event test suite [Was: Re: RfR: Progress Events Test Cases; deadline January 28]

On Mon, 21 Jan 2013, Arthur Barstow wrote:

> On 1/20/13 7:29 AM, ext Arthur Barstow wrote:
>> On 1/20/13 12:12 AM, ext Jungkee Song wrote:
>>> 
>>> 2013. 1. 20. ?? 12:39? "Arthur Barstow" <art.barstow@nokia.com 
>>> <mailto:art.barstow@nokia.com>> ?? ??:
>>> >
>>> > On 1/19/13 10:20 AM, ext Jungkee Song wrote:
>>> >>
>>> >> I've pushed the php file in 
>>> <http://dvcs.w3.org/webapps/ProgressEvents/tests/submissions/Samsung/resources/> 
>>> but cannot find it at <w3-test.org <http://w3-test.org>> mirror. Can 
>>> anyone help?
>>> >
>>> >
>>> > Did you do a `hg push`? It appears not 
>>> <https://dvcs.w3.org/hg/webapps/summary>.
>>> 
>>> Yes, I did. The php file is included in this changeset:
>>> https://dvcs.w3.org/hg/webapps/rev/ec95ece1bbf8
>>> 
>> 
>> ATM, I am getting errors trying to access Hg but I also don't see your 
>> files in the w3c-test.org mirror so I will followup with W3C Team on that 
>> issue.
>
> Jungkee - Robin reported the PHP file will not get mirrored to w3c-test.org 
> until it is OK'ed by someone in the W3C Team.
>
> Yves, Mike - on January 18, Jungkee added the following PHP file to the 
> Samsung submission directory of the Progress Events test suite:
>
> <https://dvcs.w3.org/hg/webapps/diff/ec95ece1bbf8/ProgressEvents/tests/submissions/Samsung/resources/no-content-length.php>
>
> Would you please review it so it will be mirrored to:
>
> <http://w3c-test.org/webapps/ProgressEvents/tests/submissions/Samsung/resources/>

I'm wondering what is the intent of this, sending content with no 
content-length (and then chunked transfer-coding per HTTP/1.1 spec), or do 
double encoding.
Also the chunk size is wrong, as \r\n is added twice, and the final chunk 
is missing.
Cheers,

-- 
Baroula que barouleras, au tiéu toujou t'entourneras.

         ~~Yves

Received on Monday, 21 January 2013 15:35:55 UTC