Re: Updates to WebStorage tests

On Friday, 23 March 2012 at 22:06, Ms2ger wrote:

> Hi all,
> 
> I've made a number of changes [1] to the WebStorage event tests 
> Infraware kindly submitted, to make them use testharness.js more 
> idiomatically, and to test a couple things more thoroughly, and found a 
> small spec bug in the process [2]. I'll continue with the others later, 
> but would already appreciate it if someone could review my changes.

Did a quick review (but did not run them). Nice that you reduced a lot of complexity from the tests. Would be nicer if all the functions were all on one script tag, but that's pretty minor.  


-- 
Marcos Caceres
http://datadriven.com.au

Received on Friday, 23 March 2012 22:15:03 UTC