- From: Monica Chintala <notifications@github.com>
- Date: Thu, 16 Jul 2026 14:01:56 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1835@github.com>
Update to [service-worker-global-scope-skipwaiting](https://w3c.github.io/ServiceWorker/#dom-serviceworkerglobalscope-skipwaiting).
`skipWaiting()` resolved its promise directly from an "in parallel" block, which violates the "don't touch JS objects from parallel" rule. Wrap the resolve in a `Queue a task` on the service worker's responsible event loop.
This is part 3/6 of #1740. Split out from #1755 for focused review.
<!--
This comment and the below content is programmatically generated.
You may add a comma-separated list of anchors you'd like a
direct link to below (e.g. #idl-serializers, #idl-sequence):
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/monica-ch/ServiceWorker/pull/1835.html" title="Last updated on Jul 16, 2026, 9:01 PM UTC (f59630f)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/ServiceWorker/1835/e91ddff...monica-ch:f59630f.html" title="Last updated on Jul 16, 2026, 9:01 PM UTC (f59630f)">Diff</a>
You can view, comment on, or merge this pull request online at:
https://github.com/w3c/ServiceWorker/pull/1835
-- Commit Summary --
* Editorial: queue a task to resolve promise in ServiceWorkerGlobalScope.skipWaiting
-- File Changes --
M index.bs (2)
-- Patch Links --
https://github.com/w3c/ServiceWorker/pull/1835.patch
https://github.com/w3c/ServiceWorker/pull/1835.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1835
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/ServiceWorker/pull/1835@github.com>
Received on Thursday, 16 July 2026 21:01:59 UTC