- From: Monica Chintala <notifications@github.com>
- Date: Thu, 16 Jul 2026 14:00:31 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1834@github.com>
Update to [navigation-preload-manager-enable](https://w3c.github.io/ServiceWorker/#dom-navigationpreloadmanager-enable), [navigation-preload-manager-disable](https://w3c.github.io/ServiceWorker/#dom-navigationpreloadmanager-disable), [navigation-preload-manager-setheadervalue](https://w3c.github.io/ServiceWorker/#dom-navigationpreloadmanager-setheadervalue), and [navigation-preload-manager-getstate](https://w3c.github.io/ServiceWorker/#dom-navigationpreloadmanager-getstate).
All four methods resolved/rejected their promises directly from an "in parallel" block, which violates the "don't touch JS objects from parallel" rule. Wrap the promise-touching steps in a `Queue a task` on the responsible event loop.
This is part 2/6 of #1740. Split out from #1755 for focused review.
<!--
This comment and the below content is programmatically generated.
You may add a comma-separated list of anchors you'd like a
direct link to below (e.g. #idl-serializers, #idl-sequence):
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/monica-ch/ServiceWorker/pull/1834.html" title="Last updated on Jul 16, 2026, 9:00 PM UTC (11d1e87)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/ServiceWorker/1834/e91ddff...monica-ch:11d1e87.html" title="Last updated on Jul 16, 2026, 9:00 PM UTC (11d1e87)">Diff</a>
You can view, comment on, or merge this pull request online at:
https://github.com/w3c/ServiceWorker/pull/1834
-- Commit Summary --
* Editorial: queue a task to resolve/reject promise in NavigationPreloadManager
-- File Changes --
M index.bs (23)
-- Patch Links --
https://github.com/w3c/ServiceWorker/pull/1834.patch
https://github.com/w3c/ServiceWorker/pull/1834.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1834
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/ServiceWorker/pull/1834@github.com>
Received on Thursday, 16 July 2026 21:00:36 UTC