Re: [whatwg/dom] Trusted types attributes (PR #1268)

@otherdaniel commented on this pull request.



> @@ -7514,7 +7572,23 @@ string <var>value</var>, run these steps:
  <li><p>If <var>attribute</var>'s <a for=Attr>element</a> is null, then set <var>attribute</var>'s
  <a for=Attr>value</a> to <var>value</var>.
 
- <li><p>Otherwise, <a lt="change an attribute">change</a> <var>attribute</var> to <var>value</var>.
+ <li>
+  <p>Otherwise:
+
+  <ol>
+   <li><p>Let <var>originalElement</var> be <var>attribute</var>'s <a for=Attr>element</a>.
+
+   <li><p>Let <var>verifiedValue</var> be the result of calling <a>verify attribute value</a>
+   given <var>value</var>, <var>attribute</var>, and <a>this</a>.
+
+   <li><p>If <var>attribute</var>'s <a for=Attr>element</a> is null, then set <var>attribute</var>'s
+   <a for=Attr>value</a> to <var>value</var>, and return.

Should this set Attr/value to `verifiedValue` (instead of `value`)?

WPT trusted-types/set-attributes-mutations-in-callback.tentative.html seems to expect verifiedValue here, and I get a number test failures if I implement this as written.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1268#pullrequestreview-2682437284
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1268/review/2682437284@github.com>