- From: Luke Warlow <notifications@github.com>
- Date: Mon, 17 Mar 2025 08:07:14 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1268/review/2690935840@github.com>
@lukewarlow commented on this pull request. > @@ -7514,7 +7572,23 @@ string <var>value</var>, run these steps: <li><p>If <var>attribute</var>'s <a for=Attr>element</a> is null, then set <var>attribute</var>'s <a for=Attr>value</a> to <var>value</var>. - <li><p>Otherwise, <a lt="change an attribute">change</a> <var>attribute</var> to <var>value</var>. + <li> + <p>Otherwise: + + <ol> + <li><p>Let <var>originalElement</var> be <var>attribute</var>'s <a for=Attr>element</a>. + + <li><p>Let <var>verifiedValue</var> be the result of calling <a>verify attribute value</a> + given <var>value</var>, <var>attribute</var>, and <a>this</a>. + + <li><p>If <var>attribute</var>'s <a for=Attr>element</a> is null, then set <var>attribute</var>'s + <a for=Attr>value</a> to <var>value</var>, and return. (Apologies for the delay) I just looked into this and I think it should indeed be verifiedValue. I'll update the spec PR now. Just as an fyi that test specifically is out of date with the spec currently so you'll probably still gets some failures. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1268#discussion_r1998971639 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1268/review/2690935840@github.com>
Received on Monday, 17 March 2025 15:07:18 UTC