Re: [whatwg/fetch] Return a `content-encoding` header for resource timing and more (PR #1796)

@noamr commented on this pull request.



> @@ -5004,6 +5041,13 @@ steps:
 
      <li><p>Let <var>type</var> be <var>blob</var>'s {{Blob/type}}.
 
+     <li><p>Let <var>accept-coding</var> be the result of <a for="header list">getting</a>
+       `<code>Accept-Encoding</code>` from <var>request</var>'s <a for=request>header list</a>.

Wrong indentation

> @@ -5105,10 +5152,19 @@ steps:
      <li><p>Let <var>mimeType</var> be <var>dataURLStruct</var>'s
      <a for="data: URL struct">MIME type</a>, <a lt="serialize a MIME type to bytes">serialized</a>.
 
+     <li><p>Let <var>accept-coding</var> be the result of <a for="header list">getting</a>
+       `<code>Accept-Encoding</code>` from <var>request</var>'s <a for=request>header list</a>.

Wrong indentation

> @@ -5004,6 +5041,13 @@ steps:
 
      <li><p>Let <var>type</var> be <var>blob</var>'s {{Blob/type}}.
 
+     <li><p>Let <var>accept-coding</var> be the result of <a for="header list">getting</a>
+       `<code>Accept-Encoding</code>` from <var>request</var>'s <a for=request>header list</a>.
+        If <var>accept-encoding</var> is not null and the server selects one of the encoding options,
+        let <var>coding</var> be the selected encoding option; otherwise, i.e., no encoding is used,

You can't have "let" in the middle of a phrase, see style in the rest of the document.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1796#pullrequestreview-2534371026
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1796/review/2534371026@github.com>

Received on Tuesday, 7 January 2025 13:47:00 UTC