Re: [whatwg/fetch] Return a `content-encoding` header for resource timing and more (PR #1796)

@guohuideng2024 commented on this pull request.



> @@ -6319,6 +6321,9 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps:
          <li><p>Let <var>codings</var> be the result of <a>extracting header list values</a> given
          `<code>Content-Encoding</code>` and <var>response</var>'s <a for=response>header list</a>.
 
+         <li><p>Set <var>response</var>'s <a for=response>body info</a>'s
+         <a for="response body info">content encoding</a> to <var>codings</var>.

My bad. I remember at some point in the past I mentioned I observed that known encoding method was checked with actually content, and mismatch would result a fetch failure. I had that kind of observation from my local tests. However I am not able to reproduce that today. And I also tried on gerrit. https://chromium-review.googlesource.com/c/chromium/src/+/6192941?checksPatchset=4&tab=checks (see the tests have passed)

I also looked and didn't find the code that does the check in "fetch". I tried a multiple encoding test and I see the value got into the HttpHeader.

So I believe I was wrong (and very sorry about that), and the current Chromium just keeps the value in the HttpHeader.





-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1796#discussion_r1927703386
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1796/review/2571055835@github.com>