- From: Guohui Deng <notifications@github.com>
- Date: Tue, 14 Jan 2025 13:30:55 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 14 January 2025 21:30:58 UTC
@guohuideng2024 commented on this pull request. > @@ -5004,6 +5041,13 @@ steps: <li><p>Let <var>type</var> be <var>blob</var>'s {{Blob/type}}. + <li><p>Let <var>accept-coding</var> be the result of <a for="header list">getting</a> + `<code>Accept-Encoding</code>` from <var>request</var>'s <a for=request>header list</a>. + If <var>accept-encoding</var> is not null and the server selects one of the encoding options, + let <var>coding</var> be the selected encoding option; otherwise, i.e., no encoding is used, Fixed. I see why the "let" in the middle of the sentence is a bad idea. However, I didn't find the style guide in this document. I found this page: https://github.com/guohuideng2024/fetch/tree/main instead, so I think the style guide may have been moved? I wonder if there is more style guide that I can study. Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1796#discussion_r1915621350 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1796/review/2551054491@github.com>
Received on Tuesday, 14 January 2025 21:30:58 UTC