Re: [whatwg/dom] moveBefore() cosmetic concerns (Issue #1335)

> We should probably close this issue as part of the commit message of the PR. That makes it easier to find it in the future.

Done! (by linking to the issue from "Closes" in the PR OP).

> As "pre-move" is now gone, I think "ensure pre-move validity" can be folded into "move".

OK. I've folded them into the move algorithm (i.e., not directly into the `moveBefore()` method steps).

> And separately it seems some notes should be fixed, such as "The above statements differ from the pre-insert algorithm." which wants to point at "ensure pre-insert validity" today.

I see. I guess we can fix this up separately, since that's in the replace algorithm and unrelated to the move before PR? Either way, I think we're ready for a re-review!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/issues/1335#issuecomment-2548784308
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/issues/1335/2548784308@github.com>