- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 17 Dec 2024 00:06:51 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 17 December 2024 08:06:55 UTC
We should probably close this issue as part of the commit message of the PR. That makes it easier to find it in the future. As "pre-move" is now gone, I think "ensure pre-move validity" can be folded into "move". This also reminded me that "ensure pre-insert validity" is not the only algorithm we have that concerns itself with those things. It's just the only one that's abstracted. https://dom.spec.whatwg.org/#concept-node-replace has a similar set of steps. I don't think there's any room for reasonable abstracting between these three sets, so we probably have to live with the duplication. And separately it seems some notes should be fixed, such as "The above statements differ from the pre-insert algorithm." which wants to point at "ensure pre-insert validity" today. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/issues/1335#issuecomment-2547747917 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/issues/1335/2547747917@github.com>
Received on Tuesday, 17 December 2024 08:06:55 UTC