Re: [w3c/push-api] Add Declarative Web Push (PR #385)

@martinthomson commented on this pull request.



> +            </li>
+            <li>
+              <p>
+                If <var>notification</var>'s [=notification/URL=] is null, then return failure.
+              </p>
+            </li>
+            <li>
+              <p>
+                Let <var>appBadge</var> be null.
+              </p>
+            </li>
+            <li>
+              <p>
+                If <var>message</var>["`app_badge`"] [=map/exists=] and
+                <var>message</var>["`app_badge`"] is an integer in the range 0 to
+                9223372036854775807, inclusive, then set <var>appBadge</var> to

Maybe you should double-check that math.

```
$ python
>>> 2**63-1
9223372036854775807
>>> 2**53-1
9007199254740991
```

(I don't like argument from precedent, as far as that goes.  Especially when it results in long strings of digits like this one.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/385#discussion_r1732141679
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/385/review/2262133737@github.com>