Re: [w3c/push-api] Add Declarative Web Push (PR #385)

@annevk commented on this pull request.



> +            </li>
+            <li>
+              <p>
+                If <var>notification</var>'s [=notification/URL=] is null, then return failure.
+              </p>
+            </li>
+            <li>
+              <p>
+                Let <var>appBadge</var> be null.
+              </p>
+            </li>
+            <li>
+              <p>
+                If <var>message</var>["`app_badge`"] [=map/exists=] and
+                <var>message</var>["`app_badge`"] is an integer in the range 0 to
+                9223372036854775807, inclusive, then set <var>appBadge</var> to

Interesting, I wonder why IDL goes beyond max safe integer. Also, I should have used the unsigned variant here so either way this is wrong: https://webidl.spec.whatwg.org/#idl-unsigned-long-long

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/385#discussion_r1732145834
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/385/review/2262140507@github.com>