Re: [w3c/push-api] Add Declarative Web Push (PR #385)

@annevk commented on this pull request.



> +                          If a notification has been shown through {{showNotification()}} at this
+                          point, then abort these steps.

I mean, this statement is monkey patching that. Certainly seems reasonable to tidy it up though. (`preventDefault()` wouldn't guarantee that a notification is shown.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/385#discussion_r1732132107
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/385/review/2262117500@github.com>