Re: [whatwg/streams] Use an AbortController instead of signaling abort on AbortSignal (PR #1279)

@MattiasBuelens requested changes on this pull request.



> +   <td><dfn>\[[abortController]]</dfn>
+   <td class="non-normative">An {{AbortController}} that can be used to abort the pending write or

These slots are sorted alphabetically. So move it up in the table, between `[[abortAlgorithm]]` and `[[closeAlgorithm]]`.

> @@ -4508,7 +4508,7 @@ closed. It is only used internally, and is never exposed to web developers.
  The <dfn id="ws-default-controller-signal" attribute
  for="WritableStreamDefaultController">signal</dfn> getter steps are:
 
- 1. Return [=this=].[=WritableStreamDefaultController/[[signal]]=].
+ 1. Return [=this=].[=WritableStreamDefaultController/[[abortController]]=].{{AbortController/signal}}.

If I understand [Bikeshed's autolink syntax](https://speced.github.io/bikeshed/#autolink-wrappers) correctly, this should do the trick:
```suggestion
 1. Return [=this=].[=WritableStreamDefaultController/[[abortController]]=].[=AbortController/signal=].
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1279#pullrequestreview-1443319050
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1279/review/1443319050@github.com>

Received on Thursday, 25 May 2023 08:17:12 UTC