Re: [whatwg/streams] Use an AbortController instead of signaling abort on AbortSignal (PR #1279)

@annevk commented on this pull request.

If you replace the getter with the appropriate reference I think this works. Thanks!

@MattiasBuelens should do the final review though.

> @@ -4508,7 +4508,7 @@ closed. It is only used internally, and is never exposed to web developers.
  The <dfn id="ws-default-controller-signal" attribute
  for="WritableStreamDefaultController">signal</dfn> getter steps are:
 
- 1. Return [=this=].[=WritableStreamDefaultController/[[signal]]=].
+ 1. Return [=this=].[=WritableStreamDefaultController/[[abortController]]=].{{AbortController/signal}}.

You need to return the value of the "internal slot" and not reference the "public" getter.

> @@ -6996,11 +6997,9 @@ above [=WritableStream/set up=] algorithm:
 [$WritableStreamDefaultControllerErrorIfNeeded$](|stream|.[=WritableStream/[[controller]]=], |e|).
 
 <p>The <dfn export for="WritableStream">signal</dfn> of a {{WritableStream}} |stream| is
-|stream|.[=WritableStream/[[controller]]=].[=WritableStreamDefaultController/[[signal]]=].
-Specifications can [=AbortSignal/add=] or [=AbortSignal/remove=] algorithms to this
-{{AbortSignal}}, or consult whether it is [=AbortSignal/aborted=] and its [=AbortSignal/abort
-reason=]. Specifications must not [=AbortSignal/signal abort=], as that would interfere with the
-normal use of this signal to respond to the stream being [=abort a writable stream|aborted=].
+|stream|.[=WritableStream/[[controller]]=].[=WritableStreamDefaultController/[[abortController]]=].{{AbortController/signal}}.

Same as above, cannot use the getter.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1279#pullrequestreview-1443212300
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1279/review/1443212300@github.com>