- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 02 May 2023 04:41:17 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 2 May 2023 11:41:23 UTC
@annevk commented on this pull request. When reviewing the commit message I realized this would remove "follow" and thus impact Fetch and Streams. I started looking at what this would mean for Fetch in https://github.com/whatwg/fetch/pull/1646 which also made me realize that maybe the internal composite variable is set too eagerly. I suggest we work out the dependent PRs for Fetch and Streams to ensure we don't miss anything. > - <li><p>If <var>parentSignal</var> is [=AbortSignal/aborted=], then - <a for=AbortSignal>signal abort</a> on <var>followingSignal</var> with <var>parentSignal</var>'s - [=AbortSignal/abort reason=]. + <li><p>Set <var>resultSignal</var>'s [=AbortSignal/composite=] to true. Should we only do this after iteration and only if _signals_ is not the empty list? Not sure why we would return a composite signal if any of the dependent signals is already aborted for instance or if there are no dependent signals. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1152#pullrequestreview-1408927102 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1152/review/1408927102@github.com>
Received on Tuesday, 2 May 2023 11:41:23 UTC