Re: [whatwg/streams] Editorial: Add missing argument to cancel and abort wrapper algorithms (PR #1275)

@nidhijaju commented on this pull request.

Few suggestions, but lgtm :)

> @@ -6659,9 +6659,9 @@ to grow organically as needed.
      otherwise. If this throws an exception |e|, return [=a promise rejected with=] |e|.
   1. If |result| is a {{Promise}}, then return |result|.
   1. Return [=a promise resolved with=] undefined.
- 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps:
-  1. Let |result| be the result of running |cancelAlgorithm|, if |cancelAlgorithm| was given, or
-     null otherwise. If this throws an exception |e|, return [=a promise rejected with=] |e|.
+ 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps given a value |reason|:

```suggestion
 1. Let |cancelAlgorithmWrapper| be an algorithm, taking a |reason| argument, that runs these steps:
```

> @@ -6631,9 +6631,9 @@ to grow organically as needed.
      otherwise. If this throws an exception |e|, return [=a promise rejected with=] |e|.
   1. If |result| is a {{Promise}}, then return |result|.
   1. Return [=a promise resolved with=] undefined.
- 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps:
-  1. Let |result| be the result of running |cancelAlgorithm|, if |cancelAlgorithm| was given, or
-     null otherwise. If this throws an exception |e|, return [=a promise rejected with=] |e|.
+ 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps given a value |reason|:

```suggestion
 1. Let |cancelAlgorithmWrapper| be an algorithm, taking a |reason| argument, that runs these steps:
```

> @@ -6954,9 +6954,9 @@ for="ReadableStream">locked</dfn> if ! [$IsReadableStreamLocked$](|stream|) retu
      null otherwise. If this throws an exception |e|, return [=a promise rejected with=] |e|.
   1. If |result| is a {{Promise}}, then return |result|.
   1. Return [=a promise resolved with=] undefined.
- 1. Let |abortAlgorithmWrapper| be an algorithm that runs these steps:
-  1. Let |result| be the result of running |abortAlgorithm|, if |abortAlgorithm| was given, or
-     null otherwise. If this throws an exception |e|, return [=a promise rejected with=] |e|.
+ 1. Let |abortAlgorithmWrapper| be an algorithm that runs these steps given a value |reason|:

```suggestion
 1. Let |abortAlgorithmWrapper| be an algorithm, taking a |reason| argument, that runs these steps:
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1275#pullrequestreview-1393131105
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1275/review/1393131105@github.com>