- From: Matthew Olsson <notifications@github.com>
- Date: Thu, 20 Apr 2023 09:06:53 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 20 April 2023 16:06:59 UTC
@mattco98 commented on this pull request. > @@ -6659,9 +6659,9 @@ to grow organically as needed. otherwise. If this throws an exception |e|, return [=a promise rejected with=] |e|. 1. If |result| is a {{Promise}}, then return |result|. 1. Return [=a promise resolved with=] undefined. - 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps: - 1. Let |result| be the result of running |cancelAlgorithm|, if |cancelAlgorithm| was given, or - null otherwise. If this throws an exception |e|, return [=a promise rejected with=] |e|. + 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps given a value |reason|: I took this phrasing from elsewhere in the spec, and the phrasing you suggest doesn't occur. Is there a reason to introduce a third phrasing for this? I say third because in addition to the phrasing I used, there is also "Let |xyzAlgorithm| be the following steps, taking a |foo| argument:" -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1275#discussion_r1172809860 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/streams/pull/1275/review/1394332641@github.com>
Received on Thursday, 20 April 2023 16:06:59 UTC