Re: [whatwg/fullscreen] Remove top layer definitions, now that CSS Position 4 contains them. (PR #223)

I think the prose here looks good and it's just a question of what the behavior should be in two cases. For the "already in top layer case", I think it's a very rare situation in practice, but there are the situations I can think of worth testing:
- Requesting fullscreen on the same element twice (should be unaffected)
- Switching between two elements in fullscreen by calling `a.requestFullscreen()` and `b.requestFullscreen()` in turns, over and over. This would have worked before this change, but not any longer.
- An open `<dialog>` or `popver` element in top layer in some position other than the top, so most likely nested popovers and requesting fullscreen on a popover that isn't currently on top.

@tabatkins what do you think about the second case here?

To also respond to your PR description:

> I'm having trouble getting Firefox to successfully fullscreen something so I can test this.

Do you have the test code available that you were trying?

> Potentially we could kill both by keeping the ID in the spec, but just having it explicitly say that the definition has been moved to CSS Position. Would that be better?

Do you have open PRs for all specs that link to the IDs that will go away? If so I think it's fine to let the cross-spec links be broken for a short time.

> More generally, for all the IDs that are being moved to Position, do you want to keep them in the spec with a redirect section?

I would say no. @annevk how have you done things for other specs?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/223#issuecomment-1514911752
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/223/c1514911752@github.com>