Re: [whatwg/fullscreen] Remove top layer definitions, now that CSS Position 4 contains them. (PR #223)

@foolip commented on this pull request.



>  
 <p>To <dfn>unfullscreen an <var>element</var></dfn>, unset <var>element</var>'s
-<a>fullscreen flag</a> and <a>iframe fullscreen flag</a> (if any), and <a for=set>remove</a> it from
-its <a>node document</a>'s <a>top layer</a>.
+<a>fullscreen flag</a> and <a>iframe fullscreen flag</a> (if any), and
+<a>request removal from the top layer</a> for it from its <a>node document</a>.

What are the consequences of removing the fullscreen flag immediately but doing async removal from top layer? The `:fullscreen` pseudo-class will stop matching right away, so will a transition out of fullscreen really work? I don't understand the details about how style updates happen during these frames, so I'm just asking first, I don't know what's correct.

_If_ the `:fullscreen` pseudo-class should keep matching during the transition, then we need something like "wait for removal from top layer to finish" before unsetting the fullscreen flag.

>  
 <p>All <a for=/>documents</a> have an associated <dfn>list of pending fullscreen events</dfn>, which
 is an <a>ordered set</a> of (<a>string</a>, <a>element</a>) <a>tuples</a>. It is initially empty.
 
-<p>To <dfn>fullscreen an <var>element</var></dfn>, set <var>element</var>'s <a>fullscreen flag</a>
-and <a for="top layer">add</a> it to its <a>node document</a>'s <a>top layer</a>.
+<p>To <dfn>fullscreen an <var>element</var></dfn>, set <var>element</var>'s <a>fullscreen flag</a>.
+If <var>element</var> is not currently [=in the top layer=] of its <a>node document</a>,

This is where the important behavioral change (not moving to the top of top layer) is. Once settled, can you add a note here describing the non-obvious consequences if the element _is_ already in top layer? Right now it might be:

> Note: If element is already in the top layer, it will not be moved, and may be obscured by other elements later in top layer.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/223#pullrequestreview-1392263775
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/223/review/1392263775@github.com>