- From: Ryosuke Niwa <notifications@github.com>
- Date: Thu, 06 Oct 2022 10:12:24 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 6 October 2022 17:12:36 UTC
@rniwa commented on this pull request. > @@ -4185,8 +4185,8 @@ elements. SVG ought to do the same for its <{script}> elements, but does not cal at the moment. <p>To <dfn export id=concept-node-clone lt="clone a node" local-lt="clone">clone</dfn> a -<var>node</var>, with an optional <var>document</var> and <i>clone children flag</i>, run these -steps: +<var>node</var>, with an optional <var>document</var>, <i>clone children flag</i>, and +<i>clone shadows flag</i>, run these steps: So I'd much prefer adding a new method like `createInstance` on `template` element to process declarative shadow DOM over declarative shadow DOM being a thing inside `template` content, and adding a special case to cloning steps. `importNode` has a bad default of not deep cloning anyway and many people end up sub-optimally calling `template.content.cloneNode(true)` instead of `importNode`. Adding an explicit instantiating method on `template` would solve those issues. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/892#discussion_r989297958 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/892/review/1133371989@github.com>
Received on Thursday, 6 October 2022 17:12:36 UTC