Re: [whatwg/dom] Add declarative Shadow DOM features (#892)

@annevk commented on this pull request.

I got the impression this isn't ready for a more detailed review as of yet, especially as there appears to be agreement to make somewhat significant changes. Let me know if I'm mistaken.

> @@ -6835,9 +6887,15 @@ for <a>this</a>.
  <dd><p><a>Throw</a> a "{{SyntaxError!!exception}}" {{DOMException}}.
 </dl>
 
+<p>The
+<dfn method for=Element><code>getInnerHTML(<var>options</var>)</code></dfn>
+method, when invoked, must return the result of running <a>HTML fragment serialization algorithm</a>,
+given <a>this</a> as <var>node</var>, <i>options.includeShadowRoots</i> as <i>include shadow roots</i>,
+and <i>options.closedRoots</i> as <i>closed shadow roots</i>.

Coming back to this thread in 2022, dropping this feature for now and starting a new thread on it might be the easiest path forward for the remainder to get merged.

> @@ -4185,8 +4185,8 @@ elements. SVG ought to do the same for its <{script}> elements, but does not cal
 at the moment.
 
 <p>To <dfn export id=concept-node-clone lt="clone a node" local-lt="clone">clone</dfn> a
-<var>node</var>, with an optional <var>document</var> and <i>clone children flag</i>, run these
-steps:
+<var>node</var>, with an optional <var>document</var>, <i>clone children flag</i>, and
+<i>clone shadows flag</i>, run these steps:

Presumably this will have to change anyway as part of enabling streaming, right? I would expect all logic to end up in the parser, but I might be missing something.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/892#pullrequestreview-1132564577
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/892/review/1132564577@github.com>