- From: Mason Freed <notifications@github.com>
- Date: Wed, 26 Oct 2022 18:32:20 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 27 October 2022 01:32:33 UTC
@mfreed7 commented on this pull request.
> @@ -4185,8 +4185,8 @@ elements. SVG ought to do the same for its <{script}> elements, but does not cal
at the moment.
<p>To <dfn export id=concept-node-clone lt="clone a node" local-lt="clone">clone</dfn> a
-<var>node</var>, with an optional <var>document</var> and <i>clone children flag</i>, run these
-steps:
+<var>node</var>, with an optional <var>document</var>, <i>clone children flag</i>, and
+<i>clone shadows flag</i>, run these steps:
I think there's already confusion about the difference between `cloneNode` and `importNode`. E.g. [this SO post](https://stackoverflow.com/questions/39372886/document-importnode-vs-node-clonenode-real-example), or even [this post](https://github.com/GoogleChromeLabs/howto-components/issues/133) where strong experts aren't sure of the difference. In my own testing, I don't find a performance difference.
Having said all of that, the solution doesn't seem to be adding a third way to clone templates...
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/892#discussion_r1006322095
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/dom/pull/892/review/1157479072@github.com>
Received on Thursday, 27 October 2022 01:32:33 UTC