Re: [whatwg/streams] Release reader immediately when shutting down a pipe (PR #1208)

@ricea commented on this pull request.



> @@ -475,6 +483,20 @@ function WritableStreamDefaultWriterGetDesiredSize(writer) {
   return WritableStreamDefaultControllerGetDesiredSize(stream._controller);
 }
 
+function WritableStreamDefaultWriterIsOrBecomesErrored(writer, errorListener) {

Maybe since this is not part of the standard, it should start with a lower-case letter?

> +        if (dest._state !== 'writable' || WritableStreamCloseQueuedOrInFlight(dest) === true) {
+          return promiseResolvedWith(true);
+        }

I personally don't think we need to update the spec text.

> -      is or becomes "`errored`", then
+      is or becomes "`erroring`" or "`errored`", then

Agreed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1208#pullrequestreview-861707562
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1208/review/861707562@github.com>