Re: [whatwg/streams] Release reader immediately when shutting down a pipe (PR #1208)

@MattiasBuelens commented on this pull request.



> @@ -475,6 +483,20 @@ function WritableStreamDefaultWriterGetDesiredSize(writer) {
   return WritableStreamDefaultControllerGetDesiredSize(stream._controller);
 }
 
+function WritableStreamDefaultWriterIsOrBecomesErrored(writer, errorListener) {

Sure. 👍 

What do you suggest we *do* put in the spec text?
* We can add a note saying that "errors must be propagated backward" must be handled *synchronously* as soon as that condition becomes true, in other words that it's not enough to add an *asynchronous* callback to `writer.closed`.
* We can add a note in `WritableStreamStartErroring` below the "set `stream.[[state]]` to `"erroring"`" step to remind implementers that *this* is where that condition from `pipeTo()` can become true.
* Alternatively, we tell implementers to look at the reference implementation for an example on how to do it... 😛 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1208#discussion_r791524743

You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1208/review/862016897@github.com>