Re: [whatwg/streams] Use abort reason in ReadableStreamPipeTo (PR #1182) from Mattias Buelens on 2021-10-27 (public-webapps-github@w3.org from October 2021)

From: Mattias Buelens <notifications@github.com>
Date: Wed, 27 Oct 2021 01:59:07 -0700
To: whatwg/streams <streams@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/streams/pull/1182/review/790348820@github.com>

@MattiasBuelens commented on this pull request.



> -    |stream|.[=WritableStream/[[controller]]=].[=WritableStreamDefaultController/[[signal]]=].
+    |stream|.[=WritableStream/[[controller]]=].[=WritableStreamDefaultController/[[signal]]=] with
+    |reason|.

That reminds me: we need tests! 😅

I suppose you can start by reverting web-platform-tests/wpt#31293 and replacing `ctrl.abortReason` with `ctrl.signal.reason`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1182#discussion_r737255621

Received on Wednesday, 27 October 2021 08:59:20 UTC