Re: [whatwg/streams] Use abort reason in ReadableStreamPipeTo (PR #1182)

@MattiasBuelens commented on this pull request.



> -    |stream|.[=WritableStream/[[controller]]=].[=WritableStreamDefaultController/[[signal]]=].
+    |stream|.[=WritableStream/[[controller]]=].[=WritableStreamDefaultController/[[signal]]=] with
+    |reason|.

Don't forget about the reference implementation! 😉 
https://github.com/whatwg/streams/blob/4b6b93c69e531e2fe45a6ed4cb1484a7ba4eb8bb/reference-implementation/lib/abstract-ops/writable-streams.js#L110


Note that `abortController.abort(reason)` won't do anything with `reason` yet, so it'll still behave like `abortController.abort()`. That might be a problem if we update the WPT tests, e.g. if we change [this test](https://github.com/web-platform-tests/wpt/blob/a43ea460b71db5a4692cbcd896d0f9ad844bc60c/streams/writable-streams/aborting.any.js#L1387-L1388) to:
```diff
  ws.abort(e);
  assert_true(ctrl.signal.aborted);
+ assert_equals(ctrl.signal.reason, e);
```
Since the reference implementation runs inside a [jsdom](https://github.com/jsdom/jsdom) environment, we'll have to wait until jsdom updates their `AbortController` and `AbortSignal` implementations.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1182#pullrequestreview-790346001