Re: [whatwg/dom] Add declarative Shadow DOM features (#892)

@rniwa commented on this pull request.



> @@ -5828,6 +5855,11 @@ dictionary ShadowRootInit {
   required ShadowRootMode mode;
   boolean delegatesFocus = false;
 };
+
+dictionary GetInnerHTMLOptions {
+  boolean includeShadowRoots = true;
+  sequence<ShadowRoot> closedRoots;

To match the selection API, this should be instead instead called getComposedInnerHTML and simply take an array of closed shadow roots.

I really don't think we should add this one off API before we can reach a better consensus on what the general approach on how to define all these APIs for the composed tree & flat tree. We need to stop introducing these one-off APIs with slightly different semantics. We've done enough damages to the web platform already. We need to stop.

Beyond that, I have some issues with the semantics of how serialization is proposed. I'd add a new comment on https://github.com/whatwg/html/pull/5465/files.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/892#discussion_r579592866