- From: Ryosuke Niwa <notifications@github.com>
- Date: Thu, 18 Feb 2021 16:54:56 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 19 February 2021 00:55:08 UTC
@rniwa commented on this pull request. > @@ -5828,6 +5855,11 @@ dictionary ShadowRootInit { required ShadowRootMode mode; boolean delegatesFocus = false; }; + +dictionary GetInnerHTMLOptions { + boolean includeShadowRoots = true; + sequence<ShadowRoot> closedRoots; I continue to find this API shape problematic. We really want to have a consistent API surface. Given the [current consensus](https://github.com/WICG/webcomponents/issues/79#issuecomment-432974389) for `getComposedRange` for `Selection` is that it takes a list of shadow roots regardless of their closed-ness, we should match that convention and always take a list of shadow roots here as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/892#pullrequestreview-593774559
Received on Friday, 19 February 2021 00:55:08 UTC