- From: Boris Zbarsky <notifications@github.com>
- Date: Thu, 20 Feb 2020 12:49:07 -0800
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <heycam/webidl/pull/840/review/362222386@github.com>
bzbarsky commented on this pull request. > + 1. If |descriptor| has a \[[Configurable]] field and |descriptor|.\[[Configurable]] is + <emu-val>false</emu-val>, return <emu-val>false</emu-val>. + 1. If |descriptor| has a \[[Enumerable]] field and |descriptor|.\[[Enumerable]] is + <emu-val>false</emu-val>, return <emu-val>false</emu-val>. + 1. If |descriptor| has a \[[Writable]] field and |descriptor|.\[[Writable]] is + <emu-val>false</emu-val>, return <emu-val>false</emu-val>. + 1. If [=!=] [$ToUint32$](|P|) > |oldLen|, return <emu-val>false</emu-val>. + 1. Let |idlValue| be the result of [=converted to an IDL value|converting=] + |descriptor|.\[[Value]] to the type given by |handler|.\[[Type]]. + 1. Let |existingDescriptor| be [=!=] [$OrdinaryGetOwnProperty$](|O|, |P|). + 1. Assert: |existingDescriptor| is not <emu-val>undefined</emu-val>. + 1. Let |existingIDLValue| be the result of [=converted to an IDL value|converting=] + |existingDescriptor|.\[[Value]] to the type given by |handler|.\[[Type]]. + 1. Assert: the above step never throws an exception, since we already went through the + conversions when we first stored the value. + 1. Perform the algorithm steps given by |handler|.\[[DeleteAlgorithm]], given Yeah. I think this might be less of an issue in the new setup, depending on how mutations of the backing store are structured; will take a look. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/840#discussion_r382249183
Received on Thursday, 20 February 2020 20:49:20 UTC