- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 20 Feb 2020 12:23:50 -0800
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <heycam/webidl/pull/840/review/362207815@github.com>
domenic commented on this pull request. > + 1. Let |handler| be the <emu-val>this</emu-val> value. + 1. If |P| [=is an array index=], then: + 1. Let |oldLenDesc| be [=!=] [$OrdinaryGetOwnProperty$](|O|, "length"). + 1. Assert: [=!=] [$IsDataDescriptor$](|oldLenDesc|) is <emu-val>true</emu-val>. + 1. Let |oldLen| be |oldLenDesc|.\[[Value]]. + 1. If [=!=] [$ToUint32$](|P|) ≠ |oldLen|, return <emu-val>false</emu-val>. + 1. Let |existingDescriptor| be [=!=] [$OrdinaryGetOwnProperty$](|O|, |P|). + 1. Assert: |existingDescriptor| is not <emu-val>undefined</emu-val>. + 1. Let |idlValue| be the result of [=converted to an IDL value|converting=] + |existingDescriptor|.\[[Value]] to the type given by |handler|.\[[Type]]. + 1. Assert: the above step never throws an exception, since we already went through the + conversions in + <a href="#es-observable-array-defineProperty">the <code>defineProperty</code> trap</a>. + 1. Perform the algorithm steps given by |handler|.\[[DeleteAlgorithm]], given + |idlValue| and |P|. + 1. Perform [=!=] |O|.\[[Delete]](|O|, |P|). Ah yes, you're right. But, this section got rewritten anyway in the latest version... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/840#discussion_r382237710
Received on Thursday, 20 February 2020 20:24:02 UTC