- From: Victor Costan <notifications@github.com>
- Date: Wed, 12 Feb 2020 18:41:40 -0800
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 13 February 2020 02:41:53 UTC
@kenchris Thank you very much for the feedback! We tried to balance two concerns, and ended up in an admittedly odd situation. We'd appreciate the TAG's guidance here! On one hand, we wanted to match `get`, `set`, and `delete` in the ES6 `Map`. So, we wanted to be able to support `cookieStore.get(cookieName)`, `cookieStore.set(cookieName, cookieValue)` and `cookieStore.delete(cookieName)`. On the other hand, we wanted to let the users get a cookie dictionary from `get` or `getAll`, modify it, and be able to pass it back to `set`. In other words, we wanted to be able to support `const cookieData = cookieStore.get(cookieName); cookieStore.set(cookieData);` One more issue I wanted to highlight is that the `name` argument / option to `get` and `getAll` isn't necessarily the full name of the cookie. When the `matchType` option is `"starts-with"`, the name is a prefix. We're looking forward to your guidance! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/469#issuecomment-585521420
Received on Thursday, 13 February 2020 02:41:53 UTC