Re: [whatwg/fetch] Revisit `destination` for `<iframe>`, `<frame>`, `<embed>`, and `<object>`. (#948)

mikewest commented on this pull request.



>  
 <p>A <dfn export>navigation request</dfn> is a <a for=/>request</a> whose
 <a for=request>destination</a> is
-"<code>document</code>".
+"<code>document</code>", "<code>embed</code>", "<code>frame</code>", "<code>iframe</code>",
+or "<code>object</code>".

1. Didn't we decide that `object` and `embed` requests bypassed Service Workers?

2. Assuming it's not a no-op from that perspective, it looks like "navigation request" is used three times in `ServiceWorker`. Perhaps @jakearchibald and @jungkees could weigh in on the latter two, as I'm not sure I understand what they're trying to do:

    * 12.3 of https://w3c.github.io/ServiceWorker/#on-fetch-request-algorithm (which is a no-op, as it will never match "the navigation triggering it was initiated with a shift+reload or equivalent")
    * 12.7 of https://w3c.github.io/ServiceWorker/#on-fetch-request-algorithm 
    * 19.9 of https://w3c.github.io/ServiceWorker/#terminate-service-worker-algorithm

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/948#discussion_r377647249

Received on Tuesday, 11 February 2020 13:54:45 UTC