Re: [whatwg/fetch] Revisit `destination` for `<iframe>`, `<frame>`, `<embed>`, and `<object>`. (#948)

annevk commented on this pull request.

Overall this looks reasonable, but I have a remaining concern on "navigation request". Also, do we have exhaustive test coverage and are existing tests for destination updated?

It would help if you could write the commit message that goes with this change which summarizes all the interconnected changes and tests and links those.

>  
 <p>A <dfn export>navigation request</dfn> is a <a for=/>request</a> whose
 <a for=request>destination</a> is
-"<code>document</code>".
+"<code>document</code>", "<code>embed</code>", "<code>frame</code>", "<code>iframe</code>",
+or "<code>object</code>".

Does this work for the uses in https://w3c.github.io/ServiceWorker/? Also, do these always have a reserved client and replaces client id? I don't think so right? All of that is rather messy at the moment I suppose and embed/object are somewhat poorly understood, so maybe waggling in the right direction is good enough.

cc @jakearchibald @jungkees 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/948#pullrequestreview-356642459